Add slice and limit methods to ReadData - #156
Conversation
* add default methods * concrete implementation in ByteArraySplittableReadData * add test
* add two implementations * add KeyValueAccess size and createReadData methods * update ReadDataTests
* because every ReadData is splittable
|
Adds Two implemenations are provided: Main questions have to do with the behavior of slice methods relating to boundary conditions. The current behavior is ensured by
|
* document KeyValueAccessLazyReadData
|
Note: This will need revising assuming we merge #155 |
|
Overall looks good to me. Something I'm thinking of though
|
just to clarify - |
* TODO behavior of HttpKvaReadData currently undefined
…plittable-readdata # Conflicts: # src/main/java/org/janelia/saalfeldlab/n5/FileSystemKeyValueAccess.java # src/main/java/org/janelia/saalfeldlab/n5/HttpKeyValueAccess.java # src/main/java/org/janelia/saalfeldlab/n5/readdata/AbstractInputStreamReadData.java
* rename helper method * rm unused byte[]
* and remove KeyValueAccessReadData class * because KVA.createReadData is preferred
* add LazyRead interface, * add HttpLazyRead, FileLazyRead * add KeyValueAccessReadData using LazyRead
* remove unused KeyValueAccessLazyReadData * make KeyValueAccessReadData package-private
Also add
splitmethod, though less sure how or whether we will use it.